[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] block/crypto: Fix memory leak in c
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] block/crypto: Fix memory leak in create error path |
|
Date: |
Wed, 4 Jul 2018 14:11:20 +0100 |
|
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Jul 04, 2018 at 02:58:02PM +0200, Kevin Wolf wrote:
> Fixes: Coverity CID 1393782
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/crypto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/crypto.c b/block/crypto.c
> index 994172a3de..146d81c90a 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -551,7 +551,7 @@ static int coroutine_fn
> block_crypto_co_create_opts_luks(const char *filename,
> /* Create protocol layer */
> ret = bdrv_create_file(filename, opts, errp);
> if (ret < 0) {
> - return ret;
> + goto fail;
> }
>
> bs = bdrv_open(filename, NULL, NULL,
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|