Re: [Qemu-block] [Qemu-devel] [PULL v2 09/12] block/blklogwrites: Add an option for appending to an old log

[Ari Sundholm]

On 07/05/2018 07:06 PM, Eric Blake wrote:
> On 07/05/2018 05:26 AM, Kevin Wolf wrote:
> > From: Ari Sundholm <address@hidden>
> >
> > Suggested by Kevin Wolf. May be useful when testing multiple batches
> > of writes or doing long-term testing involving restarts of the VM.
> >
> > Signed-off-by: Ari Sundholm <address@hidden>
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >   qapi/block-core.json |   3 +-
> >   block/blklogwrites.c | 147 
> > ++++++++++++++++++++++++++++++++++++++++++++++-----
> >   2 files changed, 135 insertions(+), 15 deletions(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index a9eab8cab8..d1753a2ae7 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -3062,7 +3062,8 @@
> >   { 'struct': 'BlockdevOptionsBlklogwrites',
> >     'data': { 'file': 'BlockdevRef',
> >               'log': 'BlockdevRef',
> > -            '*log-sector-size': 'uint32' } }
> > +            '*log-sector-size': 'uint32',
> > +            '*log-append': 'bool' } }
>
> Missing documentation (including the default value) of the new member. 
> Since this is already pulled, please submit a followup patch.

I somehow missed your message. Sorry.

Thanks for spotting this. I just sent a patch to add the missing 
documentation.

Thanks,
Ari Sundholm
address@hidden