[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 1/7] iotests: 153: Fix dead code
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 1/7] iotests: 153: Fix dead code |
Date: |
Thu, 12 Jul 2018 18:31:46 +0200 |
From: Fam Zheng <address@hidden>
This step was left behind my mistake. As suggested by the echoed text,
the intention was to test two devices with the same image, with
different options. The behavior should be the same as two QEMU
processes. Complete it.
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
tests/qemu-iotests/153 | 2 ++
tests/qemu-iotests/153.out | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
index 673813cd39..0daeb1b005 100755
--- a/tests/qemu-iotests/153
+++ b/tests/qemu-iotests/153
@@ -162,6 +162,7 @@ for opts1 in "" "read-only=on"
"read-only=on,force-share=on"; do
_cleanup_qemu
done
+test_opts="read-only=off read-only=on read-only=on,force-share=on"
for opt1 in $test_opts; do
for opt2 in $test_opts; do
echo
@@ -170,6 +171,7 @@ for opt1 in $test_opts; do
done
done
+echo
echo "== Creating ${TEST_IMG}.[abc] ==" | _filter_testdir
(
$QEMU_IMG create -f qcow2 "${TEST_IMG}.a" -b "${TEST_IMG}"
diff --git a/tests/qemu-iotests/153.out b/tests/qemu-iotests/153.out
index 3492ba7a29..93eaf10486 100644
--- a/tests/qemu-iotests/153.out
+++ b/tests/qemu-iotests/153.out
@@ -369,6 +369,31 @@ _qemu_img_wrapper bench -U -w -c 1 TEST_DIR/t.qcow2
qemu-img: Could not open 'TEST_DIR/t.qcow2': force-share=on can only be used
with read-only images
Round done
+
+== Two devices with the same image (read-only=off - read-only=off) ==
+QEMU_PROG: -drive if=none,file=TEST_DIR/t.qcow2,read-only=off: Failed to get
"write" lock
+Is another process using the image?
+
+== Two devices with the same image (read-only=off - read-only=on) ==
+QEMU_PROG: -drive if=none,file=TEST_DIR/t.qcow2,read-only=on: Failed to get
shared "write" lock
+Is another process using the image?
+
+== Two devices with the same image (read-only=off -
read-only=on,force-share=on) ==
+
+== Two devices with the same image (read-only=on - read-only=off) ==
+QEMU_PROG: -drive if=none,file=TEST_DIR/t.qcow2,read-only=off: Failed to get
"write" lock
+Is another process using the image?
+
+== Two devices with the same image (read-only=on - read-only=on) ==
+
+== Two devices with the same image (read-only=on -
read-only=on,force-share=on) ==
+
+== Two devices with the same image (read-only=on,force-share=on -
read-only=off) ==
+
+== Two devices with the same image (read-only=on,force-share=on -
read-only=on) ==
+
+== Two devices with the same image (read-only=on,force-share=on -
read-only=on,force-share=on) ==
+
== Creating TEST_DIR/t.qcow2.[abc] ==
Formatting 'TEST_DIR/t.IMGFMT.a', fmt=IMGFMT size=33554432
backing_file=TEST_DIR/t.IMGFMT
Formatting 'TEST_DIR/t.IMGFMT.b', fmt=IMGFMT size=33554432
backing_file=TEST_DIR/t.IMGFMT
--
2.13.6
- [Qemu-block] [PULL 0/7] Block layer fixes for 3.0-rc1, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 2/7] iotests: nbd: Stop qemu-nbd before remaking image, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 3/7] qemu-img: Document copy offloading implications with -S and -c, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 4/7] file-posix: specify expected filetypes, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 5/7] iotests: add test 226 for file driver types, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 6/7] scsi-disk: Block Device Characteristics emulation fix, Kevin Wolf, 2018/07/12
- [Qemu-block] [PULL 1/7] iotests: 153: Fix dead code,
Kevin Wolf <=
- [Qemu-block] [PULL 7/7] qemu-img: align result of is_allocated_sectors, Kevin Wolf, 2018/07/12
- Re: [Qemu-block] [PULL 0/7] Block layer fixes for 3.0-rc1, Peter Maydell, 2018/07/12