Re: [Qemu-block] [PATCH 1/5] nvme: PCI/e configuration from specification

[David Sariel]

Our bad. Change-Id tag snuck into those from gerrit
(https://review.gerrithub.io/c/davidsaOpenu/qemu/+/415434).

Took a note to replace this line with "[PATCH v2]" but, I guess, it makes sense
if additional comments will follow, right?

Thanks for taking a look.

On 12 July 2018 at 14:47, Kevin Wolf <address@hidden> wrote:

Am 22.06.2018 um 13:22 hat Shimi Gersner geschrieben:
> PCI/e configuration currently does not meets specifications.
>
> Patch includes various configuration changes to support specifications
> - BAR2 to return zero when read and CMD.IOSE is not set.
> - Expose NVME configuration through IO space (Optional).
> - PCI Power Management v1.2.
> - PCIe Function Level Reset.
> - Disable QEMUs default use of PCIe Link Status (DLLLA).
> - PCIe missing AOC compliance flag.
> - Mask PCIe End-to-End TLP as RO (Unspecified by specification).
>
> Change-Id: I9057f56266db16b013fa194730c998d4779cede3

What is the meaning of this Change-Id tag?

> Signed-off-by: Shimi Gersner <address@hidden>

Keith, can you have a look at this series?

Kevin

--

מדעי המחשב, האוניברסיטה הפתוחה

CS Dept, Open University of Israel