Re: [Qemu-block] [PATCH for-3.0 3/3] qemu-iotests: Test query-blockstats with -drive and -blockdev

[Kevin Wolf]

Am 27.07.2018 um 17:12 hat Eric Blake geschrieben:
> On 07/27/2018 09:15 AM, Kevin Wolf wrote:
> > Make sure that query-blockstats returns information for every
> > BlockBackend that is named or attached to a device model (or both).
> 
> Needed for libvirt switching over to -blockdev, so even though we're rather
> late in the 3.0 cycle, I can understand it going in now.
> 
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> > +++ b/tests/qemu-iotests/227.out
> > @@ -0,0 +1,42 @@
> > +QA output created by 227
> > +
> > +=== blockstats with -drive if=virtio ===
> > +
> > +Testing: -drive driver=null-co,if=virtio
> > +QMP_VERSION
> > +{"return": {}}
> > +{"return": [{"device": "virtio0", "stats": {"flush_total_time_ns": 0, 
> > "wr_highest_offset": 0, "wr_total_time_ns": 0, "failed_wr_operations": 0, 
> > "failed_rd_operations": 0, "wr_merged": 0, "wr_bytes": 0, "timed_stats": 
> > [], "failed_flush_operations": 0, "account_invalid": true, 
> > "rd_total_time_ns": 0, "flush_operations": 0, "wr_operations": 0, 
> > "rd_merged": 0, "rd_bytes": 0, "invalid_flush_operations": 0, 
> > "account_failed": true, "rd_operations": 0, "invalid_wr_operations": 0, 
> > "invalid_rd_operations": 0}, "node-name": "NODE_NAME", "qdev": 
> > "/machine/peripheral-anon/device[0]/virtio-backend"}]}
> 
> Long lines. Would it be worth writing the test to use QMP pretty mode?

Good idea. I'll do that before applying the patches.

Kevin