[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/5] iotests: use python logging
From: |
Max Reitz |
Subject: |
Re: [PATCH v5 0/5] iotests: use python logging |
Date: |
Fri, 4 Oct 2019 17:39:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 18.09.19 01:45, John Snow wrote:
> This series uses python logging to enable output conditionally on
> iotests.log(). We unify an initialization call (which also enables
> debugging output for those tests with -d) and then make the switch
> inside of iotests.
>
> It will help alleviate the need to create logged/unlogged versions
> of all the various helpers we have made.
>
> V5:
> - Rebased again
> - Allow Python tests to run on any platform
>
> V4:
> - Rebased on top of kwolf/block at the behest of mreitz
>
> V3:
> - Rebased for 4.1+; now based on main branch.
>
> V2:
> - Added all of the other python tests I missed to use script_initialize
> - Refactored the common setup as per Ehabkost's suggestion
> - Added protocol arguments to common initialization,
> but this isn't strictly required.
I’m OK to take the series as-is (it doesn’t affect any auto tests, so we
can decide what to do about non-Linux platforms in make check at a later
point), but there seems to be something you wanted to fix up in patch 5.
(And there’s also Kevin’s pending pull request that changes a bit of
iotests.py.)
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v5 0/5] iotests: use python logging,
Max Reitz <=