[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] nbd: Allow description when creating NBD blockdev
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v2 2/2] nbd: Allow description when creating NBD blockdev |
Date: |
Fri, 11 Oct 2019 07:41:20 +0000 |
11.10.2019 0:00, Eric Blake wrote:
> Allow blockdevs to match the feature already present in qemu-nbd -D.
> Enhance iotest 223 to cover it.
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> qapi/block.json | 8 +++++---
> blockdev-nbd.c | 9 ++++++++-
> monitor/hmp-cmds.c | 4 ++--
> tests/qemu-iotests/223 | 2 +-
> tests/qemu-iotests/223.out | 1 +
> 5 files changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/qapi/block.json b/qapi/block.json
> index 145c268bb646..a6617b5bd03a 100644
> --- a/qapi/block.json
> +++ b/qapi/block.json
> @@ -250,9 +250,11 @@
> # @name: Export name. If unspecified, the @device parameter is used as the
> # export name. (Since 2.12)
> #
> +# @description: Free-form description of the export. (Since 4.2)
Worth mention maximum of 4096?
> +#
> # @writable: Whether clients should be able to write to the device via the
> # NBD connection (default false).
> -
> +#
> # @bitmap: Also export the dirty bitmap reachable from @device, so the
> # NBD client can use NBD_OPT_SET_META_CONTEXT with
> # "qemu:dirty-bitmap:NAME" to inspect the bitmap. (since 4.0)
> @@ -263,8 +265,8 @@
> # Since: 1.3.0
> ##
[..]
--
Best regards,
Vladimir