[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] IDE: deprecate ide-drive
From: |
Peter Krempa |
Subject: |
Re: [PATCH v2 1/1] IDE: deprecate ide-drive |
Date: |
Fri, 11 Oct 2019 11:12:47 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
> On 10/10/19 7:54 AM, Peter Krempa wrote:
> > On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
> >> On 10/10/19 1:26 PM, Peter Krempa wrote:
[...]
> > To be honest, I didn't really review the code nor the documentation.
> > I actually reviewed only the idea itself in the context of integration
> > with libvirt and that's why I didn't go for 'Reviewed-by:'.
> >
> > The gist of the citation above is that we should stick to well known
> > tags with their well known meanings and I think that considering this a
> > 'review' would be a stretch of the definiton.
> >
>
> I wasn't aware that PMM wanted to avoid non-standard tags; I consider
> them to be for human use, but I can change that behavior.
>
> Peter, I'll change it to an ACK (as suggested by Kevin) is that's OK by you.
Sure! I'll spell it out even for compliance:
ACKed-by: Peter Krempa <address@hidden>
signature.asc
Description: PGP signature
- [PATCH v2 0/1] IDE: Deprecate ide-drive, John Snow, 2019/10/09
- [PATCH v2 1/1] IDE: deprecate ide-drive, John Snow, 2019/10/09
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Thomas Huth, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Markus Armbruster, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Philippe Mathieu-Daudé, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Peter Krempa, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Philippe Mathieu-Daudé, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Peter Krempa, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, Kevin Wolf, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, John Snow, 2019/10/10
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive,
Peter Krempa <=
- Re: [PATCH v2 1/1] IDE: deprecate ide-drive, John Snow, 2019/10/11