[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/19] block: reverse order for reopen commits
From: |
John Snow |
Subject: |
[PULL 10/19] block: reverse order for reopen commits |
Date: |
Fri, 11 Oct 2019 17:25:41 -0400 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
It's needed to fix reopening qcow2 with bitmaps to RW. Currently it
can't work, as qcow2 needs write access to file child, to mark bitmaps
in-image with IN_USE flag. But usually children goes after parents in
reopen queue and file child is still RO on qcow2 reopen commit. Reverse
reopen order to fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Acked-by: Max Reitz <address@hidden>
Acked-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
block.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index aaf5d796284..c548885608d 100644
--- a/block.c
+++ b/block.c
@@ -3486,10 +3486,16 @@ int bdrv_reopen_multiple(BlockReopenQueue *bs_queue,
Error **errp)
bs_entry->perms_checked = true;
}
- /* If we reach this point, we have success and just need to apply the
- * changes
+ /*
+ * If we reach this point, we have success and just need to apply the
+ * changes.
+ *
+ * Reverse order is used to comfort qcow2 driver: on commit it need to
write
+ * IN_USE flag to the image, to mark bitmaps in the image as invalid. But
+ * children are usually goes after parents in reopen-queue, so go from last
+ * to first element.
*/
- QTAILQ_FOREACH(bs_entry, bs_queue, entry) {
+ QTAILQ_FOREACH_REVERSE(bs_entry, bs_queue, entry) {
bdrv_reopen_commit(&bs_entry->state);
}
--
2.21.0
- Re: [PULL 01/19] util/hbitmap: strict hbitmap_reset, (continued)
[PULL 02/19] block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c, John Snow, 2019/10/11
[PULL 03/19] block/dirty-bitmap: return int from bdrv_remove_persistent_dirty_bitmap, John Snow, 2019/10/11
[PULL 04/19] block/qcow2: proper locking on bitmap add/remove paths, John Snow, 2019/10/11
[PULL 05/19] block/dirty-bitmap: drop meta, John Snow, 2019/10/11
[PULL 07/19] block/dirty-bitmap: drop BdrvDirtyBitmap.mutex, John Snow, 2019/10/11
[PULL 06/19] block/dirty-bitmap: add bs link, John Snow, 2019/10/11
[PULL 08/19] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next, John Snow, 2019/10/11
[PULL 09/19] block: switch reopen queue from QSIMPLEQ to QTAILQ, John Snow, 2019/10/11
[PULL 10/19] block: reverse order for reopen commits,
John Snow <=
[PULL 11/19] iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW, John Snow, 2019/10/11
[PULL 12/19] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps, John Snow, 2019/10/11
[PULL 13/19] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint(), John Snow, 2019/10/11
[PULL 14/19] block/qcow2-bitmap: do not remove bitmaps on reopen-ro, John Snow, 2019/10/11
[PULL 16/19] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw, John Snow, 2019/10/11
[PULL 15/19] iotests: add test 260 to check bitmap life after snapshot + commit, John Snow, 2019/10/11
[PULL 17/19] qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit, John Snow, 2019/10/11
[PULL 18/19] MAINTAINERS: Add Vladimir as a reviewer for bitmaps, John Snow, 2019/10/11
[PULL 19/19] dirty-bitmaps: remove deprecated autoload parameter, John Snow, 2019/10/11
Re: [PULL 00/19] Bitmaps patches, Peter Maydell, 2019/10/14