[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] qemu-nbd: Support help options for --object
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 4/4] qemu-nbd: Support help options for --object |
Date: |
Mon, 14 Oct 2019 11:47:02 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 11.10.2019 um 23:39 hat Eric Blake geschrieben:
> On 10/11/19 3:55 PM, Kevin Wolf wrote:
> > Instead of parsing help options as normal object properties and
> > returning an error, provide the same help functionality as the system
> > emulator in qemu-nbd, too.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
>
> Missing a change in qemu-nbd.texi for man page coverage.
Hm... Both qemu-img and qemu-nbd manpages refer to qemu(1) for the
details. I wouldn't mind copying the text for '-object help' from there
anyway, but unfortunately it doesn't even exist. :-)
So this looks like a separate patch that fixes it for qemu, too.
> But the patch is a strict improvement, so even if we have to add a
> followup patch for documentation, I'm okay with:
>
> Reviewed-by: Eric Blake <address@hidden>
>
> This patch touches NBD, but I'm assuming it's easier to take the series
> through your tree.
Yes, thanks.
Kevin