[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/7] iotests: Selfish patches
From: |
Max Reitz |
Subject: |
Re: [PATCH v4 0/7] iotests: Selfish patches |
Date: |
Mon, 14 Oct 2019 16:59:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 17.09.19 11:19, Max Reitz wrote:
> Hi,
>
> Again, let me start with a link to an actually explanatory cover letter:
> https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg01102.html
>
> v3:
> https://lists.nongnu.org/archive/html/qemu-block/2019-08/msg00950.html
>
> v4:
> - I merged the old patch 1 in the meantime
>
> - Patch 2: Adjusted the comment to make it more clear that it is
> case_notrun() itself that will not skip the test case, as
> requested by Andrey (I hope it fits what he had in mind, more
> or less); kept the R-bs, because I somehow feel like that’s
> the right thing to do here.
>
> - Patch 3: The func_wrapper returned by the skip_test_decorator has a
> mandatory argument; make that and its required type explicit
> (with an annotation), as suggested by John
> (Kevin made me aware of the fact that annotations exist since
> Python 3.0, it’s just that they didn’t mean anything back
> then (neither do they really now, but whatever, it’s better
> than a comment))
>
> - Patch 4: Resolved a conflict because of the change to patch 3
Thanks for the reviews, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v4 0/7] iotests: Selfish patches,
Max Reitz <=