[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/15] replay: disable default snapshot for record/replay
From: |
Kevin Wolf |
Subject: |
[PULL 03/15] replay: disable default snapshot for record/replay |
Date: |
Mon, 14 Oct 2019 18:03:37 +0200 |
From: Pavel Dovgalyuk <address@hidden>
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
vl.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 0a295e5d77..fce9ce2364 100644
--- a/vl.c
+++ b/vl.c
@@ -1203,7 +1203,7 @@ static void configure_blockdev(BlockdevOptionsQueue
*bdo_queue,
qapi_free_BlockdevOptions(bdo->bdo);
g_free(bdo);
}
- if (snapshot || replay_mode != REPLAY_MODE_NONE) {
+ if (snapshot) {
qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot,
NULL, NULL);
}
@@ -3066,7 +3066,13 @@ int main(int argc, char **argv, char **envp)
drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
break;
case QEMU_OPTION_snapshot:
- snapshot = 1;
+ {
+ Error *blocker = NULL;
+ snapshot = 1;
+ error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+ "-snapshot");
+ replay_add_blocker(blocker);
+ }
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
--
2.20.1
- [PULL 00/15] Block layer patches, Kevin Wolf, 2019/10/14
- [PULL 01/15] block/vhdx: add check for truncated image files, Kevin Wolf, 2019/10/14
- [PULL 02/15] block: implement bdrv_snapshot_goto for blkreplay, Kevin Wolf, 2019/10/14
- [PULL 03/15] replay: disable default snapshot for record/replay,
Kevin Wolf <=
- [PULL 04/15] replay: update docs for record/replay with block devices, Kevin Wolf, 2019/10/14
- [PULL 05/15] replay: don't drain/flush bdrv queue while RR is working, Kevin Wolf, 2019/10/14
- [PULL 06/15] replay: finish record/replay before closing the disks, Kevin Wolf, 2019/10/14
- [PULL 07/15] replay: add BH oneshot event for block layer, Kevin Wolf, 2019/10/14
- [PULL 09/15] iotests/028: Fix for long $TEST_DIRs, Kevin Wolf, 2019/10/14
- [PULL 08/15] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK, Kevin Wolf, 2019/10/14
- Re: [PULL 00/15] Block layer patches, Peter Maydell, 2019/10/15