[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__()
From: |
John Snow |
Subject: |
Re: [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__() |
Date: |
Thu, 17 Oct 2019 17:08:54 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
"fields" in the commit message.
On 10/16/19 3:24 PM, Eduardo Habkost wrote:
> This makes the formatting code simpler, and safer if we change
> the type of self.value from str to bytes.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> tests/image-fuzzer/qcow2/layout.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/image-fuzzer/qcow2/layout.py
> b/tests/image-fuzzer/qcow2/layout.py
> index 6501c9fd4b..0adcbd448d 100644
> --- a/tests/image-fuzzer/qcow2/layout.py
> +++ b/tests/image-fuzzer/qcow2/layout.py
> @@ -53,8 +53,8 @@ class Field(object):
> return iter([self.fmt, self.offset, self.value, self.name])
>
> def __repr__(self):
> - return "Field(fmt='%s', offset=%d, value=%s, name=%s)" % \
> - (self.fmt, self.offset, str(self.value), self.name)
> + return "Field(fmt=%r, offset=%r, value=%r, name=%r)" % \
> + (self.fmt, self.offset, self.value, self.name)
>
>
> class FieldsList(object):
>
- [PATCH 00/10] image-fuzzer: Port to Python 3, Eduardo Habkost, 2019/10/16
- [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file, Eduardo Habkost, 2019/10/16
- [PATCH 01/10] image-fuzzer: Open image files in binary mode, Eduardo Habkost, 2019/10/16
- [PATCH 03/10] image-fuzzer: Explicitly use integer division operator, Eduardo Habkost, 2019/10/16
- [PATCH 04/10] image-fuzzer: Use io.StringIO, Eduardo Habkost, 2019/10/16
- [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__(), Eduardo Habkost, 2019/10/16
- Re: [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__(),
John Snow <=
- [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions, Eduardo Habkost, 2019/10/16
- [PATCH 07/10] image-fuzzer: Use bytes constant for field values, Eduardo Habkost, 2019/10/16
- [PATCH 08/10] image-fuzzer: Encode file name and file format to bytes, Eduardo Habkost, 2019/10/16
- [PATCH 09/10] image-fuzzer: Run using python3, Eduardo Habkost, 2019/10/16
- [PATCH 10/10] image-fuzzer: Use errors parameter of subprocess.Popen(), Eduardo Habkost, 2019/10/16
- Re: [PATCH 00/10] image-fuzzer: Port to Python 3, John Snow, 2019/10/17