[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation
From: |
Thomas Huth |
Subject: |
Re: [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation |
Date: |
Mon, 21 Oct 2019 14:14:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 19/10/2019 08.38, Stefan Hajnoczi wrote:
> VIRTIO Device Initialization requires feature negotiation. The libqos
> virtio-9p driver lacks feature negotiation and is therefore
> non-compliant.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/libqos/virtio-9p.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/libqos/virtio-9p.c b/tests/libqos/virtio-9p.c
> index 8c9efce3e1..77dbfb62ad 100644
> --- a/tests/libqos/virtio-9p.c
> +++ b/tests/libqos/virtio-9p.c
> @@ -32,6 +32,12 @@ static void virtio_9p_cleanup(QVirtio9P *interface)
>
> static void virtio_9p_setup(QVirtio9P *interface)
> {
> + uint64_t features;
> +
> + features = qvirtio_get_features(interface->vdev);
> + features &= ~(QVIRTIO_F_BAD_FEATURE | (1ull << VIRTIO_RING_F_EVENT_IDX));
> + qvirtio_set_features(interface->vdev, features);
Same question as with patch 4: Why just disabling these two bits and not
rather set the bits we know about?
Thomas
- Re: [PATCH v3 02/16] libqos: read QVIRTIO_MMIO_VERSION register, (continued)
- [PATCH v3 03/16] libqos: extend feature bits to 64-bit, Stefan Hajnoczi, 2019/10/19
- [PATCH v3 04/16] virtio-scsi-test: add missing feature negotiation, Stefan Hajnoczi, 2019/10/19
- [PATCH v3 05/16] tests/virtio-blk-test: set up virtqueue after feature negotiation, Stefan Hajnoczi, 2019/10/19
- [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation, Stefan Hajnoczi, 2019/10/19
- Re: [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation,
Thomas Huth <=
- [PATCH v3 07/16] libqos: enforce Device Initialization order, Stefan Hajnoczi, 2019/10/19
[PATCH v3 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step, Stefan Hajnoczi, 2019/10/19
[PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian, Stefan Hajnoczi, 2019/10/19