[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] block/block-copy: refactor copying
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 3/6] block/block-copy: refactor copying |
Date: |
Tue, 22 Oct 2019 11:53:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote:
> Merge copying code into one function block_copy_do_copy, which only
> calls bdrv_ io functions and don't do any synchronization (like dirty
> bitmap set/reset).
>
> Refactor block_copy() function so that it takes full decision about
> size of chunk to be copied and does all the synchronization (checking
> intersecting requests, set/reset dirty bitmaps).
>
> It will help:
> - introduce parallel processing of block_copy iterations: we need to
> calculate chunk size, start async chunk copying and go to the next
> iteration
> - simplify synchronization improvement (like memory limiting in
> further commit and reducing critical section (now we lock the whole
> requested range, when actually we need to lock only dirty region
> which we handle at the moment))
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/block-copy.c | 118 ++++++++++++++++++++-------------------------
> block/trace-events | 6 +--
> 2 files changed, 54 insertions(+), 70 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v2 6/6] block/block-copy: increase buffered copy request, (continued)
- [PATCH v2 6/6] block/block-copy: increase buffered copy request, Vladimir Sementsov-Ogievskiy, 2019/10/16
- [PATCH v2 1/6] block/block-copy: allocate buffer in block_copy_with_bounce_buffer, Vladimir Sementsov-Ogievskiy, 2019/10/16
- [PATCH v2 5/6] block/block-copy: add memory limit, Vladimir Sementsov-Ogievskiy, 2019/10/16
- [PATCH v2 4/6] util: introduce SharedResource, Vladimir Sementsov-Ogievskiy, 2019/10/16
- [PATCH v2 2/6] block/block-copy: limit copy_range_size to 16 MiB, Vladimir Sementsov-Ogievskiy, 2019/10/16
- [PATCH v2 3/6] block/block-copy: refactor copying, Vladimir Sementsov-Ogievskiy, 2019/10/16
- Re: [PATCH v2 3/6] block/block-copy: refactor copying,
Max Reitz <=