[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian
From: |
Christophe de Dinechin |
Subject: |
Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian |
Date: |
Tue, 22 Oct 2019 18:51:39 +0200 |
User-agent: |
mu4e 1.3.2; emacs 26.2 |
Stefan Hajnoczi writes:
[...]
> +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t
> addr)
> +{
> + uint16_t val = qtest_readw(qts, addr);
> +
> + if (d->features & (1ull << VIRTIO_F_VERSION_1) && qtest_big_endian(qts))
> {
For my education, I was wondering why tests use the (1ull << FEATURE)
notation and not an equivalent of virtio_has_feature()? Is this
intentional, or just legacy?
--
Cheers,
Christophe de Dinechin (IRC c3d)
- Re: [PATCH v3 07/16] libqos: enforce Device Initialization order, (continued)
[PATCH v3 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step, Stefan Hajnoczi, 2019/10/19
[PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian, Stefan Hajnoczi, 2019/10/19
[PATCH v3 10/16] libqos: add iteration support to qpci_find_capability(), Stefan Hajnoczi, 2019/10/19
[PATCH v3 11/16] libqos: pass full QVirtQueue to set_queue_address(), Stefan Hajnoczi, 2019/10/19
[PATCH v3 12/16] libqos: add MSI-X callbacks to QVirtioPCIDevice, Stefan Hajnoczi, 2019/10/19
[PATCH v3 13/16] libqos: expose common virtqueue setup/cleanup functions, Stefan Hajnoczi, 2019/10/19
[PATCH v3 14/16] libqos: make the virtio-pci BAR index configurable, Stefan Hajnoczi, 2019/10/19