[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscrip
From: |
John Snow |
Subject: |
Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript |
Date: |
Wed, 23 Oct 2019 11:41:41 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 10/21/19 5:41 PM, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
>
> Reported-by: John Snow <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: John Snow <address@hidden>
> ---
> tests/image-fuzzer/runner.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
> index 95d84f38f3..1eb2138f94 100755
> --- a/tests/image-fuzzer/runner.py
> +++ b/tests/image-fuzzer/runner.py
> @@ -159,7 +159,7 @@ class TestEnv(object):
> os.makedirs(self.current_dir)
> except OSError as e:
> print("Error: The working directory '%s' cannot be used. Reason:
> %s"\
> - % (self.work_dir, e[1]), file=sys.stderr)
> + % (self.work_dir, e.strerror), file=sys.stderr)
> raise TestException
> self.log = open(os.path.join(self.current_dir, "test.log"), "w")
> self.parent_log = open(run_log, "a")
> @@ -246,7 +246,7 @@ class TestEnv(object):
> except OSError as e:
> multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
> % (test_summary, os.path.basename(current_cmd[0]),
> - e[1]),
> + e.strerror),
> sys.stderr, self.log, self.parent_log)
> raise TestException
>
>
--
—js