[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 3/8] virtio: Free blk virqueues at unrealize()
From: |
Eugenio Pérez |
Subject: |
[PATCH v7 3/8] virtio: Free blk virqueues at unrealize() |
Date: |
Fri, 25 Oct 2019 10:35:22 +0200 |
The function virtio_del_queue was not called at unrealize() callback.
This was detected due to add an allocated element on the vq introduce
in future commits (used_elems) and running address sanitizer memory
leak detector.
Signed-off-by: Eugenio Pérez <address@hidden>
---
hw/block/virtio-blk.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index ed2ddebd2b..ba846fe9dc 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1206,9 +1206,14 @@ static void virtio_blk_device_unrealize(DeviceState
*dev, Error **errp)
{
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VirtIOBlock *s = VIRTIO_BLK(dev);
+ VirtIOBlkConf *conf = &s->conf;
+ unsigned i;
virtio_blk_data_plane_destroy(s->dataplane);
s->dataplane = NULL;
+ for (i = 0; i < conf->num_queues; i++) {
+ virtio_del_queue(vdev, i);
+ }
qemu_del_vm_change_state_handler(s->change);
blockdev_mark_auto_del(s->blk);
virtio_cleanup(vdev);
--
2.16.5
- [PATCH v7 0/8] Packed virtqueue for virtio, Eugenio Pérez, 2019/10/25
- [PATCH v7 1/8] virtio: basic structure for packed ring, Eugenio Pérez, 2019/10/25
- [PATCH v7 2/8] virtio: device/driver area size calculation refactor for split ring, Eugenio Pérez, 2019/10/25
- [PATCH v7 3/8] virtio: Free blk virqueues at unrealize(),
Eugenio Pérez <=
- [PATCH v7 4/8] virtio: Free rnd virqueue at unrealize(), Eugenio Pérez, 2019/10/25
- [PATCH v7 6/8] virtio: event suppression support for packed ring, Eugenio Pérez, 2019/10/25
- [PATCH v7 5/8] virtio: basic packed virtqueue support, Eugenio Pérez, 2019/10/25
- [PATCH v7 7/8] vhost_net: enable packed ring support, Eugenio Pérez, 2019/10/25
- [PATCH v7 8/8] virtio: add property to enable packed virtqueue, Eugenio Pérez, 2019/10/25
- Re: [PATCH v7 0/8] Packed virtqueue for virtio, Michael S. Tsirkin, 2019/10/25