[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/6] block-copy: memory limit
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 0/6] block-copy: memory limit |
Date: |
Fri, 25 Oct 2019 14:31:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 22.10.19 13:17, Vladimir Sementsov-Ogievskiy wrote:
> I'm going to bring block-status driven, async copying process to
> block-copy, to make it fast. The first step is to limit memory usage of
> backup, here is it.
>
> v3:
> 03: add Max's r-b
> 04: fix commit message and include guards, add Max's r-b
> 05-06: add Max's r-b
>
> v2: [mostly by Max's comments]
> Now based on master (Thank you Max!)
> 01: add Max's r-b
> 02: add Max's r-b
> 03: - refactor block_copy_do_copy goto/return
> - add small comment to block_copy_do_copy
> 04: - a lot of renaming and wording fixes
> - refactor to use "available" instead of "taken"
> - refactor co_get_from_shres
> 05: rebase on 04 changes
> 06: drop extra things from max_transfer calculation
>
> Vladimir Sementsov-Ogievskiy (6):
> block/block-copy: allocate buffer in block_copy_with_bounce_buffer
> block/block-copy: limit copy_range_size to 16 MiB
> block/block-copy: refactor copying
> util: introduce SharedResource
> block/block-copy: add memory limit
> block/block-copy: increase buffered copy request
>
> include/block/block-copy.h | 5 +-
> include/qemu/co-shared-resource.h | 71 ++++++++++++
> block/block-copy.c | 182 +++++++++++++++---------------
> util/qemu-co-shared-resource.c | 76 +++++++++++++
> block/trace-events | 6 +-
> util/Makefile.objs | 1 +
> 6 files changed, 249 insertions(+), 92 deletions(-)
> create mode 100644 include/qemu/co-shared-resource.h
> create mode 100644 util/qemu-co-shared-resource.c
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH v3 0/6] block-copy: memory limit, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 2/6] block/block-copy: limit copy_range_size to 16 MiB, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 1/6] block/block-copy: allocate buffer in block_copy_with_bounce_buffer, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 4/6] util: introduce SharedResource, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 6/6] block/block-copy: increase buffered copy request, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 5/6] block/block-copy: add memory limit, Vladimir Sementsov-Ogievskiy, 2019/10/22
- [PATCH v3 3/6] block/block-copy: refactor copying, Vladimir Sementsov-Ogievskiy, 2019/10/22
- Re: [PATCH v3 0/6] block-copy: memory limit,
Max Reitz <=