[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/7] block/backup: drop dead code from backup_job_create
From: |
Kevin Wolf |
Subject: |
[PULL 4/7] block/backup: drop dead code from backup_job_create |
Date: |
Fri, 25 Oct 2019 15:46:08 +0200 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
After commit 00e30f05de1d195, there is no more "goto error" points
after job creation, so after "error:" @job is always NULL and we don't
need roll-back job creation.
Reported-by: Coverity (CID 1406402)
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Acked-by: Stefano Garzarella <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/backup.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index dddcf77f53..cf62b1a38c 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -474,10 +474,7 @@ BlockJob *backup_job_create(const char *job_id,
BlockDriverState *bs,
if (sync_bitmap) {
bdrv_reclaim_dirty_bitmap(sync_bitmap, NULL);
}
- if (job) {
- backup_clean(&job->common.job);
- job_early_fail(&job->common.job);
- } else if (backup_top) {
+ if (backup_top) {
bdrv_backup_top_drop(backup_top);
}
--
2.20.1
- [PULL 0/7] Block layer patches, Kevin Wolf, 2019/10/25
- [PULL 2/7] iotests: Skip read-only cases in 118 when run as root, Kevin Wolf, 2019/10/25
- [PULL 4/7] block/backup: drop dead code from backup_job_create,
Kevin Wolf <=
- [PULL 1/7] qapi: add support for blkreplay driver, Kevin Wolf, 2019/10/25
- [PULL 5/7] doc: Describe missing generic -blockdev options, Kevin Wolf, 2019/10/25
- [PULL 3/7] blockdev: Use error_report() in hmp_commit(), Kevin Wolf, 2019/10/25
- [PULL 7/7] qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation(), Kevin Wolf, 2019/10/25
- [PULL 6/7] coroutine: Add qemu_co_mutex_assert_locked(), Kevin Wolf, 2019/10/25
- Re: [PULL 0/7] Block layer patches, Peter Maydell, 2019/10/25