[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/15] qapi/block-core: add option for io_uring
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 02/15] qapi/block-core: add option for io_uring |
Date: |
Fri, 25 Oct 2019 21:09:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> From: Aarushi Mehta <address@hidden>
>
> Only enumerates option for devices that support it.
I'm not sure I get this sentence.
> Since QAPI schema
> supports io_uring, which is the actual name of the Linux API, it is
> preferred over io-uring.
I guess this one means something like "Since io_uring is the actual name
of the Linux API, we use it as enum value even though the QAPI schema
conventions would prefer io-uring."
> Signed-off-by: Aarushi Mehta <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index b274aef713..3196f40178 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2851,11 +2851,13 @@
> #
> # @threads: Use qemu's thread pool
> # @native: Use native AIO backend (only Linux and Windows)
> +# @io_uring: Use linux io_uring (since 4.2)
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native',
> + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ]
> }
>
> ##
> # @BlockdevCacheOptions:
I encourage you to polish the commit message some.
Acked-by: Markus Armbruster <address@hidden>
- [PATCH v2 00/15] io_uring: add Linux io_uring AIO engine, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 01/15] configure: permit use of io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 02/15] qapi/block-core: add option for io_uring, Stefan Hajnoczi, 2019/10/25
- Re: [PATCH v2 02/15] qapi/block-core: add option for io_uring,
Markus Armbruster <=
- [PATCH v2 03/15] block/block: add BDRV flag for io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 05/15] stubs: add stubs for io_uring interface, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 04/15] block/io_uring: implements interfaces for io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 06/15] util/async: add aio interfaces for io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 07/15] blockdev: adds bdrv_parse_aio to use io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 08/15] block/file-posix.c: extend to use io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 09/15] block: add trace events for io_uring, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 10/15] block/io_uring: adds userspace completion polling, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 11/15] qemu-io: adds option to use aio engine, Stefan Hajnoczi, 2019/10/25
- [PATCH v2 12/15] qemu-img: adds option to use aio engine for benchmarking, Stefan Hajnoczi, 2019/10/25