[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespa
From: |
Klaus Birkelund |
Subject: |
Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces |
Date: |
Mon, 28 Oct 2019 07:09:40 +0100 |
User-agent: |
Mutt/1.12.2 (2019-09-21) |
On Tue, Oct 15, 2019 at 12:38:40PM +0200, Klaus Jensen wrote:
> Hi,
>
> (Quick note to Fam): most of this series is irrelevant to you as the
> maintainer of the nvme block driver, but patch "nvme: add support for
> scatter gather lists" touches block/nvme.c due to changes in the shared
> NvmeCmd struct.
>
> Anyway, v2 comes with a good bunch of changes. Compared to v1[1], I have
> squashed some commits in the beginning of the series and heavily
> refactored "nvme: support multiple block requests per request" into the
> new commit "nvme: allow multiple aios per command".
>
> I have also removed the original implementation of the Abort command
> (commit "nvme: add support for the abort command") as it is currently
> too tricky to test reliably. It has been replaced by a stub that,
> besides a trivial sanity check, just fails to abort the given command.
> *Some* implementation of the Abort command is mandatory, but given the
> "best effort" nature of the command this is acceptable for now. When the
> device gains support for arbitration it should be less tricky to test.
>
> The support for multiple namespaces is now backwards compatible. The
> nvme device still accepts a 'drive' parameter, but for multiple
> namespaces the use of 'nvme-ns' devices are required. I also integrated
> some feedback from Paul so the device supports non-consecutive namespace
> ids.
>
> I have also added some new commits at the end:
>
> - "nvme: bump controller pci device id" makes sure the Linux kernel
> doesn't apply any quirks to the controller that it no longer has.
> - "nvme: handle dma errors" won't actually do anything before this[2]
> fix to include/hw/pci/pci.h is merged. With these two patches added,
> the device reliably passes some additional nasty tests from blktests
> (block/011 "disable PCI device while doing I/O" and block/019 "break
> PCI link device while doing I/O"). Before this patch, block/011
> would pass from time to time if you were lucky, but would at least
> mess up the controller pretty badly, causing a reset in the best
> case.
>
>
> [1]: https://patchwork.kernel.org/project/qemu-devel/list/?series=142383
> [2]: https://patchwork.kernel.org/patch/11184911/
>
>
> Klaus Jensen (20):
> nvme: remove superfluous breaks
> nvme: move device parameters to separate struct
> nvme: add missing fields in the identify controller data structure
> nvme: populate the mandatory subnqn and ver fields
> nvme: allow completion queues in the cmb
> nvme: add support for the abort command
> nvme: refactor device realization
> nvme: add support for the get log page command
> nvme: add support for the asynchronous event request command
> nvme: add logging to error information log page
> nvme: add missing mandatory features
> nvme: bump supported specification version to 1.3
> nvme: refactor prp mapping
> nvme: allow multiple aios per command
> nvme: add support for scatter gather lists
> nvme: support multiple namespaces
> nvme: bump controller pci device id
> nvme: remove redundant NvmeCmd pointer parameter
> nvme: make lba data size configurable
> nvme: handle dma errors
>
> block/nvme.c | 18 +-
> hw/block/Makefile.objs | 2 +-
> hw/block/nvme-ns.c | 139 +++
> hw/block/nvme-ns.h | 60 ++
> hw/block/nvme.c | 1863 +++++++++++++++++++++++++++++++++-------
> hw/block/nvme.h | 219 ++++-
> hw/block/trace-events | 37 +-
> include/block/nvme.h | 132 ++-
> 8 files changed, 2094 insertions(+), 376 deletions(-)
> create mode 100644 hw/block/nvme-ns.c
> create mode 100644 hw/block/nvme-ns.h
>
> --
> 2.23.0
>
Gentle ping on this.
I'm aware that this is a lot to go through, but I would like to know if
anyone has had a chance to look at it?
https://patchwork.kernel.org/project/qemu-devel/list/?series=187637
- [PATCH v2 19/20] nvme: make lba data size configurable, (continued)
- [PATCH v2 19/20] nvme: make lba data size configurable, Klaus Jensen, 2019/10/15
- [PATCH v2 18/20] nvme: remove redundant NvmeCmd pointer parameter, Klaus Jensen, 2019/10/15
- [PATCH v2 14/20] nvme: allow multiple aios per command, Klaus Jensen, 2019/10/15
- [PATCH v2 15/20] nvme: add support for scatter gather lists, Klaus Jensen, 2019/10/15
- [PATCH v2 13/20] nvme: refactor prp mapping, Klaus Jensen, 2019/10/15
- [PATCH v2 16/20] nvme: support multiple namespaces, Klaus Jensen, 2019/10/15
- [PATCH v2 20/20] nvme: handle dma errors, Klaus Jensen, 2019/10/15
- Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces, no-reply, 2019/10/15
- Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces, no-reply, 2019/10/15
- Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces, Fam Zheng, 2019/10/16
- Re: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces,
Klaus Birkelund <=