[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/7] iotests: Skip test 060 if it is not possible to creat
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v2 2/7] iotests: Skip test 060 if it is not possible to create large files |
Date: |
Thu, 5 Dec 2019 13:41:18 -0500 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Dec 04, 2019 at 04:46:13PM +0100, Thomas Huth wrote:
> Test 060 fails in the arm64, s390x and ppc64le LXD containers on Travis
> (which we will hopefully enable in our CI soon). These containers
> apparently do not allow large files to be created. The repair process
> in test 060 creates a file of 64 GiB, so test first whether such large
> files are possible and skip the test if that's not the case.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> tests/qemu-iotests/060 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060
> index b91d8321bb..d96f17a484 100755
> --- a/tests/qemu-iotests/060
> +++ b/tests/qemu-iotests/060
> @@ -49,6 +49,9 @@ _supported_fmt qcow2
> _supported_proto file
> _supported_os Linux
>
> +# The repair process will create a large file - so check for availability
> first
> +_require_large_file 64G
> +
> rt_offset=65536 # 0x10000 (XXX: just an assumption)
> rb_offset=131072 # 0x20000 (XXX: just an assumption)
> l1_offset=196608 # 0x30000 (XXX: just an assumption)
> --
> 2.18.1
>
The behavior and failure is indeed pretty consistent accross those
architectures:
- arm64: https://travis-ci.org/clebergnu/qemu/jobs/621238740#L4217
- ppc64le: https://travis-ci.org/clebergnu/qemu/jobs/621238741#L4252
- s390x: https://travis-ci.org/clebergnu/qemu/jobs/621238742#L4265
And with this, 060 gets skipped properly:
- arm64: https://travis-ci.org/clebergnu/qemu/jobs/621248591#L4202
- ppc64le: https://travis-ci.org/clebergnu/qemu/jobs/621248592#L4236
- s390x: https://travis-ci.org/clebergnu/qemu/jobs/621248593#L4250
Reviewed-by: Cleber Rosa <address@hidden>
Tested-by: Cleber Rosa <address@hidden>
- [PATCH v2 0/7] Enable Travis builds on arm64, ppc64le and s390x, Thomas Huth, 2019/12/04
- [PATCH v2 1/7] iotests: Provide a function for checking the creation of huge files, Thomas Huth, 2019/12/04
- [PATCH v2 2/7] iotests: Skip test 060 if it is not possible to create large files, Thomas Huth, 2019/12/04
- [PATCH v2 6/7] configure: allow disable of cross compilation containers, Thomas Huth, 2019/12/04
- [PATCH v2 3/7] iotests: Skip test 079 if it is not possible to create large files, Thomas Huth, 2019/12/04
- [PATCH v2 7/7] travis.yml: Enable builds on arm64, ppc64le and s390x, Thomas Huth, 2019/12/04
- [PATCH v2 4/7] tests/hd-geo-test: Skip test when images can not be created, Thomas Huth, 2019/12/04
- [PATCH v2 5/7] tests/test-util-filemonitor: Skip test on non-x86 Travis containers, Thomas Huth, 2019/12/04