[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/10] iotests: 207: Remove duplication with VM.blockdev_create()
From: |
Kevin Wolf |
Subject: |
[PATCH 09/10] iotests: 207: Remove duplication with VM.blockdev_create() |
Date: |
Mon, 16 Dec 2019 18:08:56 +0100 |
The blockdev_create() function in this test case adds another filter to
the logging, but provides otherwise the same functionality as
VM.blockdev_create() from iotests.py. Make it a thin wrapper around the
iotests.py function.
Signed-off-by: Kevin Wolf <address@hidden>
---
tests/qemu-iotests/207 | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/207 b/tests/qemu-iotests/207
index ec8c1d06f0..812ab34e47 100755
--- a/tests/qemu-iotests/207
+++ b/tests/qemu-iotests/207
@@ -35,13 +35,7 @@ def filter_hash(qmsg):
return iotests.filter_qmp(qmsg, _filter)
def blockdev_create(vm, options):
- result = vm.qmp_log('blockdev-create', job_id='job0', options=options,
- filters=[iotests.filter_qmp_testfiles, filter_hash])
-
- if 'return' in result:
- assert result['return'] == {}
- vm.run_job('job0')
- iotests.log("")
+ vm.blockdev_create(options, filters=[iotests.filter_qmp_testfiles,
filter_hash])
with iotests.FilePath('t.img') as disk_path, \
iotests.VM() as vm:
--
2.20.1
- [PATCH 00/10] iotests: Remove duplicated blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 02/10] iotests: 255: Drop blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 01/10] iotests: Create VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 04/10] iotests: 210: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 03/10] iotests: 206: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 05/10] iotests: 212: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 06/10] iotests: 213: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 10/10] iotests: 211: Remove duplication with VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 07/10] iotests: 237: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 08/10] iotests: 266: Convert to VM.blockdev_create(), Kevin Wolf, 2019/12/16
- [PATCH 09/10] iotests: 207: Remove duplication with VM.blockdev_create(),
Kevin Wolf <=