[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 22/24] nvme: bump controller pci device id
From: |
Klaus Birkelund Jensen |
Subject: |
Re: [PATCH v4 22/24] nvme: bump controller pci device id |
Date: |
Thu, 19 Dec 2019 18:24:57 +0100 |
On Dec 20 01:16, Keith Busch wrote:
> On Thu, Dec 19, 2019 at 02:09:19PM +0100, Klaus Jensen wrote:
> > @@ -2480,7 +2480,7 @@ static void nvme_init_pci(NvmeCtrl *n, PCIDevice
> > *pci_dev)
> > pci_conf[PCI_INTERRUPT_PIN] = 1;
> > pci_config_set_prog_interface(pci_conf, 0x2);
> > pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL);
> > - pci_config_set_device_id(pci_conf, 0x5845);
> > + pci_config_set_device_id(pci_conf, 0x5846);
> > pci_config_set_class(pci_conf, PCI_CLASS_STORAGE_EXPRESS);
> > pcie_endpoint_cap_init(pci_dev, 0x80);
>
> We can't just pick a number here, these are supposed to be assigned by the
> vendor. A day will come when I will be in trouble for using the existing
> identifier: I found out to late it was supposed to be for internal use
> only as it was never officially reserved, so lets not make the same
> mistake for some future device.
>
Makes sense. And there is no "QEMU" vendor, is there? But it would be
really nice to get rid of the quirks.
Message not available
Message not available
Message not available
Message not available
Message not available
Message not available
Message not available
Message not available