Re: [Qemu-devel] [PATCH 1/2] LUKS: better error message when creating too large files

[Maxim Levitsky]

On Thu, 2020-04-30 at 15:18 +0300, Maxim Levitsky wrote:
> On Mon, 2019-07-22 at 10:05 +0100, Daniel P. Berrangé wrote:
> > On Sun, Jul 21, 2019 at 09:15:07PM +0300, Maxim Levitsky wrote:
> > > Currently if you attampt to create too large file with luks you
> > > get the following error message:
> > > 
> > > Formatting 'test.luks', fmt=luks size=17592186044416 key-secret=sec0
> > > qemu-img: test.luks: Could not resize file: File too large
> > > 
> > > While for raw format the error message is
> > > qemu-img: test.img: The image size is too large for file format 'raw'
> > > 
> > > 
> > > The reason for this is that qemu-img checks for errono of the failure,
> > > and presents the later error when it is -EFBIG
> > > 
> > > However crypto generic code 'swallows' the errno and replaces it
> > > with -EIO.
> > > 
> > > As an attempt to make it better, we can make luks driver,
> > > detect -EFBIG and in this case present a better error message,
> > > which is what this patch does
> > > 
> > > The new error message is:
> > > 
> > > qemu-img: error creating test.luks: The requested file size is too large
> > > 
> > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534898
> > > Signed-off-by: Maxim Levitsky <address@hidden>
> > > ---
> > >  block/crypto.c | 25 +++++++++++++++++++++----
> > >  1 file changed, 21 insertions(+), 4 deletions(-)
> > 
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> 
> 
> Could someone pick to a maintainer tree, now that freeze is over?
> 
> 
> Best regards,
>       Maxim Levitsky
> > 
> > Regards,
> > Daniel
> 
> 
I replied to an old version, please disregard,
Best regards,
        Maxim Levitsky