[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] iotests: Run pylint and mypy in a testcase
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 0/2] iotests: Run pylint and mypy in a testcase |
|
Date: |
Wed, 13 May 2020 16:56:14 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/11/20 12:35 PM, Kevin Wolf wrote:
> Kevin Wolf (2):
> iotests: Fix incomplete type declarations
> iotests: Run pylint and mypy in a testcase
>
> tests/qemu-iotests/iotests.py | 8 +++----
> tests/qemu-iotests/297 | 44 +++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/297.out | 3 +++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 52 insertions(+), 4 deletions(-)
> create mode 100755 tests/qemu-iotests/297
> create mode 100644 tests/qemu-iotests/297.out
>
Cool!
Maybe the approach of putting this in 'make check' somewhere can
alleviate that expensive test being performed in iotests directly (as
Max notes), but, uhm. whatever.
For now, this will help prevent the backslide.
Reviewed-by: John Snow <address@hidden>