[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair |
|
Date: |
Tue, 26 May 2020 17:20:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/26/20 4:55 PM, Philippe Mathieu-Daudé wrote:
> On 5/19/20 7:11 PM, Stefan Hajnoczi wrote:
>> Passing around both BDRVNVMeState and NVMeQueuePair is unwiedly. Reduce
Oh, and typo "unwieldy".
>> the number of function arguments by keeping the BDRVNVMeState pointer in
>> NVMeQueuePair. This will come in handly when a BH is introduced in a
>> later patch and only one argument can be passed to it.
>>
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>> ---
>> block/nvme.c | 70 ++++++++++++++++++++++++++++------------------------
>> 1 file changed, 38 insertions(+), 32 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>