[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create() |
|
Date: |
Fri, 03 Jul 2020 08:46:32 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 7/2/20 10:49 AM, Markus Armbruster wrote:
>> When creating an image fails because the format doesn't support option
>> "backing_file" or "backing_fmt", bdrv_img_create() first has
>> qemu_opt_set() put a generic error into @local_err, then puts the real
>> error into @errp with error_setg(), and then propagates the former to
>> the latter, which throws away the generic error. A bit complicated,
>> but works.
>>
>> Not that qemu_opt_set() returns a useful value, we can simply ignore
>
> s/Not/Now/
I missed this one when processing review comments for v2. Thanks for
reminding me!
>> the generic error instead.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>> block.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
- Re: [PATCH v2 36/44] error: Eliminate error_propagate() manually, (continued)
- [PATCH v2 25/44] qom: Use return values to check for error where that's simpler, Markus Armbruster, 2020/07/02
- [PATCH v2 43/44] qdev: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/02
- [PATCH v2 41/44] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/07/02
- [PATCH v2 12/44] qemu-option: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/02
- [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/07/02
- [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure, Markus Armbruster, 2020/07/02
- [PATCH v2 32/44] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02
- [PATCH v2 34/44] error: Eliminate error_propagate() with Coccinelle, part 1, Markus Armbruster, 2020/07/02