[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_I
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v9 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit |
|
Date: |
Fri, 03 Jul 2020 14:43:07 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 02 Jul 2020 05:13:02 PM CEST, Max Reitz wrote:
>> + } else if (!strcmp(desc->name, BLOCK_OPT_EXTL2)) {
>> + bool extended_l2 = qemu_opt_get_bool(opts, BLOCK_OPT_EXTL2,
>> + has_subclusters(s));
>> + if (extended_l2 != has_subclusters(s)) {
>> + error_setg(errp, "Toggling extended L2 entries "
>> + "is not supported");
>> + return -EINVAL;
>
> Just a note: I think ENOTSUP would fit better.
>
> (Then again, Maxim’s “block/amend: refactor qcow2 amend options”
> removes all of this code anyway.)
I can still change that :)
Berto