qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in


From: Peter Maydell
Subject: Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events
Date: Fri, 3 Jul 2020 14:28:12 +0100

On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Some ACMD were incorrectly displayed. Fix by remembering if we
> are processing a ACMD (with current_cmd_is_acmd) and add the
> sd_current_cmd_name() helper, which display to correct name
> regardless it is a CMD or ACMD.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

I think my comments on v3 of this patch still apply:
https://patchew.org/QEMU/20200605102230.21493-1-philmd@redhat.com/20200605102230.21493-10-philmd@redhat.com/

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]