[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries |
|
Date: |
Fri, 03 Jul 2020 17:20:59 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 03 Jul 2020 03:47:41 PM CEST, Max Reitz wrote:
>>>> + printf -v expected_bitmap "%llu" $expected_bitmap # Convert to
>>>> unsigned
>>>
>>> Does the length modifier “ll” actually do anything?
>>>
>>>> +
>>>> + printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry"
>>>> "$bitmap"
>>>
>>> Or the “l” here?
>>
>> Actually they don't (I just tested in i386 and x86_64), I assumed
>> that it would require the length modifiers like in C.
>>
>> I'm tempted to leave them for clarity (using 'll' in both cases),
>> opinions?
>
> I don’t mind, although at least zsh’s printf doesn’t seem to support
> them all:
>
> $ printf %lli 42
> printf: %ll: invalid directive
I went to the bash source code, and it seems that the length modifiers
are simply skipped:
https://git.savannah.gnu.org/cgit/bash.git/tree/builtins/printf.def#n412
I'll remove them then.
Berto