[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 17/17] hw/sd/sdcard: Simplify realize() a bit
From: |
Alistair Francis |
Subject: |
Re: [PATCH v7 17/17] hw/sd/sdcard: Simplify realize() a bit |
Date: |
Mon, 6 Jul 2020 09:34:32 -0700 |
On Tue, Jun 30, 2020 at 6:46 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> We don't need to check if sd->blk is set twice.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/sd/sd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 304fa4143a..8ef6715665 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2154,12 +2154,12 @@ static void sd_realize(DeviceState *dev, Error **errp)
> return;
> }
>
> - if (sd->blk && blk_is_read_only(sd->blk)) {
> - error_setg(errp, "Cannot use read-only drive as SD card");
> - return;
> - }
> -
> if (sd->blk) {
> + if (blk_is_read_only(sd->blk)) {
> + error_setg(errp, "Cannot use read-only drive as SD card");
> + return;
> + }
> +
> ret = blk_set_perm(sd->blk, BLK_PERM_CONSISTENT_READ |
> BLK_PERM_WRITE,
> BLK_PERM_ALL, errp);
> if (ret < 0) {
> --
> 2.21.3
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v7 17/17] hw/sd/sdcard: Simplify realize() a bit,
Alistair Francis <=