Re: [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, n

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, n

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, not void
Date:	Mon, 6 Jul 2020 19:58:49 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 06.07.2020 11:09, Markus Armbruster wrote:

See recent commit "error: Document Error API usage rules" for
rationale.

Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Eric Blake<eblake@redhat.com>



Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 22/44] qom: Crash more nicely on object_property_get_link() failure, (continued)
- [PATCH v3 22/44] qom: Crash more nicely on object_property_get_link() failure, Markus Armbruster, 2020/07/06
- [PATCH v3 18/44] qapi: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/06
- [PATCH v3 11/44] qemu-option: Replace opt_set() by cleaner opt_validate(), Markus Armbruster, 2020/07/06
- [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Greg Kurz, 2020/07/06
    - Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Markus Armbruster, 2020/07/06
    - Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Greg Kurz, 2020/07/07
- [PATCH v3 13/44] qemu-option: Use returned bool to check for failure, Markus Armbruster, 2020/07/06
- [PATCH v3 17/44] qapi: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/06
- [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, not void, Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part, Vladimir Sementsov-Ogievskiy, 2020/07/06
- [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Vladimir Sementsov-Ogievskiy, 2020/07/06
    - Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/06
- [PATCH v3 20/44] qom: Use error_reportf_err() instead of g_printerr() in examples, Markus Armbruster, 2020/07/06
- [PATCH v3 31/44] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/06
- [PATCH v3 08/44] qemu-option: Factor out helper find_default_by_name(), Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 08/44] qemu-option: Factor out helper find_default_by_name(), Greg Kurz, 2020/07/07
- [PATCH v3 23/44] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/07/06

Prev by Date: Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1
Next by Date: Re: [PATCH v3 00/11] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups
Previous by thread: [PATCH v3 30/44] qdev: Make functions taking Error ** return bool, not void
Next by thread: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part
Index(es):
- Date
- Thread