Re: [PATCH v7 14/47] stream: Deal with filters

[Andrey Shinkevich]

On 09.07.2020 17:52, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
> > Because of the (not so recent anymore) changes that make the stream job
> > independent of the base node and instead track the node above it, we
> > have to split that "bottom" node into two cases: The bottom COW node,
> > and the node directly above the base node (which may be an R/W filter
> > or the bottom COW node).
> >
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> >   qapi/block-core.json |  4 +++
> >   block/stream.c       | 63 ++++++++++++++++++++++++++++++++------------
> >   blockdev.c           |  4 ++-
> >   3 files changed, 53 insertions(+), 18 deletions(-)
...
> > +    BlockDriverState *base_overlay = bdrv_find_overlay(bs, base);
> > +    BlockDriverState *above_base;
> >   -    if (bdrv_freeze_backing_chain(bs, bottom, errp) < 0) {
> > +    if (!base_overlay) {
> > +        error_setg(errp, "'%s' is not in the backing chain of '%s'",
> > +                   base->node_name, bs->node_name);
>
> Sorry, I am not clear with the error message.
>
> In this case, there is no an intermediate COW node but the base, if 
> not NULL, is
>
> in the backing chain of bs, isn't it?
I am discarding this question. No need to answer.

Andrey


> > +        return;
> > +    }
> > +