[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 12/16] python/machine.py: Add _qmp access shim
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 12/16] python/machine.py: Add _qmp access shim |
|
Date: |
Mon, 13 Jul 2020 11:37:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/10/20 7:22 AM, John Snow wrote:
> Like many other Optional[] types, it's not always a given that this
> object will be set. Wrap it in a type-shim that raises a meaningful
> error and will always return a concrete type.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 02/16] iotests.py: use qemu.qmp type aliases, (continued)
- [PATCH v5 02/16] iotests.py: use qemu.qmp type aliases, John Snow, 2020/07/10
- [PATCH v5 03/16] python/qmp.py: re-absorb MonitorResponseError, John Snow, 2020/07/10
- [PATCH v5 04/16] python/qmp.py: Do not return None from cmd_obj, John Snow, 2020/07/10
- [PATCH v5 05/16] python/qmp.py: add casts to JSON deserialization, John Snow, 2020/07/10
- [PATCH v5 06/16] python/qmp.py: add QMPProtocolError, John Snow, 2020/07/10
- [PATCH v5 09/16] python/machine.py: Don't modify state in _base_args(), John Snow, 2020/07/10
- [PATCH v5 07/16] python/machine.py: Fix monitor address typing, John Snow, 2020/07/10
- [PATCH v5 08/16] python/machine.py: reorder __init__, John Snow, 2020/07/10
- [PATCH v5 10/16] python/machine.py: Handle None events in events_wait, John Snow, 2020/07/10
- [PATCH v5 12/16] python/machine.py: Add _qmp access shim, John Snow, 2020/07/10
- Re: [PATCH v5 12/16] python/machine.py: Add _qmp access shim,
Philippe Mathieu-Daudé <=
- [PATCH v5 13/16] python/machine.py: fix _popen access, John Snow, 2020/07/10
- [PATCH v5 11/16] python/machine.py: use qmp.command, John Snow, 2020/07/10
- [PATCH v5 15/16] iotests.py: Adjust HMP kwargs typing, John Snow, 2020/07/10
- [PATCH v5 14/16] python/qemu: make 'args' style arguments immutable, John Snow, 2020/07/10
- [PATCH v5 16/16] python/qemu: Add mypy type annotations, John Snow, 2020/07/10
- Re: [PATCH v5 00/16] python: add mypy support to python/qemu, Philippe Mathieu-Daudé, 2020/07/14