qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/20] iotests: 129 don't check backup "busy"


From: Max Reitz
Subject: Re: [PATCH v2 02/20] iotests: 129 don't check backup "busy"
Date: Fri, 17 Jul 2020 14:57:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Busy is racy, job has it's "pause-points" when it's not busy. Drop this
> check.

Possible, though I have to admit I don’t think I’ve ever seen 129 fail
because of that, but rather because of:

https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg00499.html

I.e. the fact that BB throttling doesn’t do anything and the job is
basically just done before query-block-jobs.

But checking @busy is probably not the best thing to do, right.

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/129 | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]