[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/16] hw/block/nvme: pass request along for tracing
|
From: |
Minwoo Im |
|
Subject: |
Re: [PATCH 06/16] hw/block/nvme: pass request along for tracing |
|
Date: |
Thu, 30 Jul 2020 00:49:36 +0900 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
Klaus,
On 20-07-20 13:37:38, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Pass along the NvmeRequest in various functions since it is very useful
> for tracing.
One doubt here.
This patch has put NvmeRequest argument to the nvme_map_prp() to trace
the request's command id. But can we just trace the cid before this
kind of prp mapping, somewhere like nvme_process_sq() level. Then we
can figure out the tracing for the prp mapping is from which request.
Tracing for cid is definitely great, but feels like too much cost to
pass argument to trace 'cid' in the middle of the dma mapping stage.
Thanks,
- [PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup, Klaus Jensen, 2020/07/20
- [PATCH 01/16] hw/block/nvme: memset preallocated requests structures, Klaus Jensen, 2020/07/20
- [PATCH 02/16] hw/block/nvme: add mapping helpers, Klaus Jensen, 2020/07/20
- [PATCH 04/16] hw/block/nvme: remove redundant has_sg member, Klaus Jensen, 2020/07/20
- [PATCH 06/16] hw/block/nvme: pass request along for tracing, Klaus Jensen, 2020/07/20
- Re: [PATCH 06/16] hw/block/nvme: pass request along for tracing,
Minwoo Im <=
- [PATCH 03/16] hw/block/nvme: replace dma_acct with blk_acct equivalent, Klaus Jensen, 2020/07/20
- [PATCH 08/16] hw/block/nvme: verify validity of prp lists in the cmb, Klaus Jensen, 2020/07/20
- [PATCH 05/16] hw/block/nvme: refactor dma read/write, Klaus Jensen, 2020/07/20
- [PATCH 10/16] hw/block/nvme: add check for mdts, Klaus Jensen, 2020/07/20