Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

[Paolo Bonzini]

On 31/07/20 19:27, Daniel P. Berrangé wrote:
> You say "main feature", I say "biggest flaw" ;-P
> 
> Doing checks on patches is the single worst thing about the way
> we do code style validation, at it means the bulk of committed code
> is never in compliance. The need to check patches is precisely because
> the committed code is unclean and so can't be checked without raising
> pages of problems.

This is true for code formatting but not for style warnings.  A stupid
example is that you need to use strtol to implement the recommended
replacement qemu_strtol. We could invent our own "allow-this" lint
syntax but it would be a much bigger job.

Paolo