Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

[Daniel P . Berrangé]

On Fri, Jul 31, 2020 at 07:42:52PM +0200, Paolo Bonzini wrote:
> On 31/07/20 19:27, Daniel P. Berrangé wrote:
> > You say "main feature", I say "biggest flaw" ;-P
> > 
> > Doing checks on patches is the single worst thing about the way
> > we do code style validation, at it means the bulk of committed code
> > is never in compliance. The need to check patches is precisely because
> > the committed code is unclean and so can't be checked without raising
> > pages of problems.
> 
> This is true for code formatting but not for style warnings.  A stupid
> example is that you need to use strtol to implement the recommended
> replacement qemu_strtol. We could invent our own "allow-this" lint
> syntax but it would be a much bigger job.

Yes, I assumed use of a mechanism for identifying exceptions, as that
is pretty standard practice for any tool that's doing whole source
tree validation. This would still be better than what we have today
because developers reading or copying the can actually then see 
whether the style violation was intentionale, as opposed to historical
accident, and thus less likely to submit patches with style violations.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|