[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/9] block: simplify comment to BDRV_REQ_SERIALISING
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v2 1/9] block: simplify comment to BDRV_REQ_SERIALISING |
Date: |
Fri, 14 Aug 2020 16:03:40 +0300 |
1. BDRV_REQ_NO_SERIALISING doesn't exist already, don't mention it.
2. We are going to add one more user of BDRV_REQ_SERIALISING, so
comment about backup becomes a bit confusing here. The use case in
backup is documented in block/backup.c, so let's just drop
duplication here.
3. The fact that BDRV_REQ_SERIALISING is only for write requests is
omitted. Add a note.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
include/block/block.h | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index 6e36154061..b8f4e86e8d 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -53,16 +53,7 @@ typedef enum {
* content. */
BDRV_REQ_WRITE_UNCHANGED = 0x40,
- /*
- * BDRV_REQ_SERIALISING forces request serialisation for writes.
- * It is used to ensure that writes to the backing file of a backup process
- * target cannot race with a read of the backup target that defers to the
- * backing file.
- *
- * Note, that BDRV_REQ_SERIALISING is _not_ opposite in meaning to
- * BDRV_REQ_NO_SERIALISING. A more descriptive name for the latter might be
- * _DO_NOT_WAIT_FOR_SERIALISING, except that is too long.
- */
+ /* Forces request serialisation. Use only with write requests. */
BDRV_REQ_SERIALISING = 0x80,
/* Execute the request only if the operation can be offloaded or otherwise
--
2.21.3
- [PATCH v2 0/9] preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 2/9] block/io.c: drop assertion on double waiting for request serialisation, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 3/9] block/io: split out bdrv_find_conflicting_request, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 4/9] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 5/9] block: bdrv_mark_request_serialising: split non-waiting function, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 1/9] block: simplify comment to BDRV_REQ_SERIALISING,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v2 6/9] block: introduce BDRV_REQ_NO_WAIT flag, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 7/9] block: introduce preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 8/9] iotests.py: add verify_o_direct helper, Vladimir Sementsov-Ogievskiy, 2020/08/14
- [PATCH v2 9/9] iotests: add 298 to test new preallocate filter driver, Vladimir Sementsov-Ogievskiy, 2020/08/14
- Re: [PATCH v2 0/9] preallocate filter, no-reply, 2020/08/14
- Re: [PATCH v2 0/9] preallocate filter, no-reply, 2020/08/14
- DROP Re: [PATCH v2 0/9] preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/14