[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare() |
|
Date: |
Mon, 17 Aug 2020 11:41:09 +0200 |
Am 14.08.2020 um 18:02 hat Pan Nengyuan geschrieben:
> 'local_err' seems forgot to propagate in error path, it'll cause
> a memleak. Fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
I wonder if using ERRP_GUARD() wouldn't simplify this. Anyway, the fix
looks correct:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>