[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation |
Date: |
Tue, 18 Aug 2020 19:11:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Cc'ing Sai Pavan for patches 1 and 2.
On 8/17/20 12:05 PM, Bin Meng wrote:
> This series is spun off from the following series as it is hw/sd
> centric, so that it can be picked up separately by Philippe.
>
> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=195648
>
> This series fixed 2 SD card issues, and added a new model for
> Cadence SDHCI controller.
>
> Patch "[09/18] hw/sd: sdhci: Make sdhci_poweron_reset() internal visible"
> in this series per the review comments.
>
> Changes in v2:
> - remove the pointless zero initialization
> - fix SDSC size check in sd_set_csd() too
> - use 's' for the model state
> - call device_cold_reset() in cadence_sdhci_reset()
> - add .impl in cadence_sdhci_ops
> - move Cadence specific register defines to cadence_sdhci.c
> - use 'sdhci' instead of 'slot' to represent SDHCIState
> - use sysbus_mmio_get_region() to access SDHCI model's memory region
> - initialize TYPE_SYSBUS_SDHCI in the instance_init() so that users
> of Cadence SDHCI do not have to do that themselves
> - propergate irq and 'sd-bus' from generic-sdhci
>
> Bin Meng (3):
> hw/sd: sd: Fix incorrect populated function switch status data
> structure
> hw/sd: sd: Correct the maximum size of a Standard Capacity SD Memory
> Card
> hw/sd: Add Cadence SDHCI emulation
>
> hw/sd/Kconfig | 4 +
> hw/sd/Makefile.objs | 1 +
> hw/sd/cadence_sdhci.c | 200
> ++++++++++++++++++++++++++++++++++++++++++
> hw/sd/sd.c | 9 +-
> include/hw/sd/cadence_sdhci.h | 46 ++++++++++
> 5 files changed, 257 insertions(+), 3 deletions(-)
> create mode 100644 hw/sd/cadence_sdhci.c
> create mode 100644 include/hw/sd/cadence_sdhci.h
>