[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: dr
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg |
|
Date: |
Wed, 19 Aug 2020 15:59:29 +0100 |
On Mon, Aug 17, 2020 at 12:15:45PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> bs is linked in req, so no needs to pass it separately. Most of
> tracked-requests API doesn't have bs argument. Actually, after this
> patch only tracked_request_begin has it, but it's for purpose.
>
> While being here, also add a comment about what "_locked" is.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/io.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation, (continued)
- [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg, Vladimir Sementsov-Ogievskiy, 2020/08/17
- Re: [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg,
Stefan Hajnoczi <=
- [PATCH v3 07/12] block: introduce preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 09/12] iotests.py: add filter_img_check, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 10/12] iotests: add 298 to test new preallocate filter driver, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 11/12] block: add bdrv_is_file_on_fuse helper, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 08/12] iotests.py: add verify_o_direct helper, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE, Vladimir Sementsov-Ogievskiy, 2020/08/17