[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 05/15] block/nvme: Improve error message when IO queue creatio
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v5 05/15] block/nvme: Improve error message when IO queue creation failed |
Date: |
Thu, 20 Aug 2020 18:58:51 +0200 |
Do not use the same error message for different failures.
Display a different error whether it is the CQ or the SQ.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 003809fbd83..53448b7d230 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -648,7 +648,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error
**errp)
.cdw11 = cpu_to_le32(0x3),
};
if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) {
- error_setg(errp, "Failed to create io queue [%d]", n);
+ error_setg(errp, "Failed to create CQ io queue [%d]", n);
nvme_free_queue_pair(q);
return false;
}
@@ -659,7 +659,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error
**errp)
.cdw11 = cpu_to_le32(0x1 | (n << 16)),
};
if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) {
- error_setg(errp, "Failed to create io queue [%d]", n);
+ error_setg(errp, "Failed to create SQ io queue [%d]", n);
nvme_free_queue_pair(q);
return false;
}
--
2.26.2
- [PATCH v5 00/15] block/nvme: Various cleanups required to use multiple queues, Philippe Mathieu-Daudé, 2020/08/20
- [PATCH v5 04/15] block/nvme: Define INDEX macros to ease code review, Philippe Mathieu-Daudé, 2020/08/20
- [PATCH v5 05/15] block/nvme: Improve error message when IO queue creation failed,
Philippe Mathieu-Daudé <=
- [PATCH v5 06/15] block/nvme: Use common error path in nvme_add_io_queue(), Philippe Mathieu-Daudé, 2020/08/20
- [PATCH v5 07/15] block/nvme: Rename local variable, Philippe Mathieu-Daudé, 2020/08/20
- [PATCH v5 08/15] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures, Philippe Mathieu-Daudé, 2020/08/20
[PATCH v5 09/15] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset, Philippe Mathieu-Daudé, 2020/08/20