[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] qemu-iotests: Support varargs syntax in FilePaths
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 3/5] qemu-iotests: Support varargs syntax in FilePaths |
Date: |
Tue, 25 Aug 2020 12:48:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 21.08.20 01:54, Nir Soffer wrote:
> Accept variable number of names instead of a sequence:
>
> with FilePaths("a", "b", "c") as (a, b, c):
>
> The disadvantage is that base_dir must be used as kwarg:
>
> with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2):
>
> But this is more clear and calling optional argument as positional
> arguments is bad idea anyway.
>
> Signed-off-by: Nir Soffer <nsoffer@redhat.com>
> ---
> tests/qemu-iotests/194 | 4 ++--
> tests/qemu-iotests/257 | 10 ++++------
> tests/qemu-iotests/iotests.py | 6 +++---
> 3 files changed, 9 insertions(+), 11 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
signature.asc
Description: OpenPGP digital signature
- [PATCH v2 0/5] iotest.FilePath fixes and cleanups, Nir Soffer, 2020/08/20
- [PATCH v2 1/5] qemu-iotests: Fix FilePaths cleanup, Nir Soffer, 2020/08/20
- [PATCH v2 2/5] qemu-iotests: Fix FilePaths docstring, Nir Soffer, 2020/08/20
- [PATCH v2 3/5] qemu-iotests: Support varargs syntax in FilePaths, Nir Soffer, 2020/08/20
- Re: [PATCH v2 3/5] qemu-iotests: Support varargs syntax in FilePaths,
Max Reitz <=
- [PATCH v2 4/5] qemu-iotests: Merge FilePaths and FilePath, Nir Soffer, 2020/08/20
- [PATCH v2 5/5] qemu-iotests: Simplify FilePath __init__, Nir Soffer, 2020/08/20
- Re: [PATCH v2 0/5] iotest.FilePath fixes and cleanups, Kevin Wolf, 2020/08/25