[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/10] block: bdrv_mark_request_serialising: split non-wai
From: |
Max Reitz |
Subject: |
Re: [PATCH v5 05/10] block: bdrv_mark_request_serialising: split non-waiting function |
Date: |
Tue, 25 Aug 2020 14:43:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
> We'll need a separate function, which will only "mark" request
> serialising with specified align but not wait for conflicting
> requests. So, it will be like old bdrv_mark_request_serialising(),
> before merging bdrv_wait_serialising_requests_locked() into it.
>
> To reduce the possible mess, let's do the following:
>
> Public function that does both marking and waiting will be called
> bdrv_make_request_serialising, and private function which will only
> "mark" will be called tracked_request_set_serialising().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block_int.h | 3 ++-
> block/file-posix.c | 2 +-
> block/io.c | 35 +++++++++++++++++++++++------------
> 3 files changed, 26 insertions(+), 14 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
signature.asc
Description: OpenPGP digital signature
- [PATCH v5 00/10] preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/21
- [PATCH v5 02/10] block/io.c: drop assertion on double waiting for request serialisation, Vladimir Sementsov-Ogievskiy, 2020/08/21
- [PATCH v5 01/10] block: simplify comment to BDRV_REQ_SERIALISING, Vladimir Sementsov-Ogievskiy, 2020/08/21
- [PATCH v5 03/10] block/io: split out bdrv_find_conflicting_request, Vladimir Sementsov-Ogievskiy, 2020/08/21
- [PATCH v5 04/10] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg, Vladimir Sementsov-Ogievskiy, 2020/08/21
- [PATCH v5 05/10] block: bdrv_mark_request_serialising: split non-waiting function, Vladimir Sementsov-Ogievskiy, 2020/08/21
- Re: [PATCH v5 05/10] block: bdrv_mark_request_serialising: split non-waiting function,
Max Reitz <=
- [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag, Vladimir Sementsov-Ogievskiy, 2020/08/21
[PATCH v5 07/10] block: introduce preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/21