[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test |
Date: |
Thu, 27 Aug 2020 11:30:02 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Aug 04, 2020 at 10:12:01AM +0200, Lukas Straub wrote:
> A connecting chardev object has an additional reference by the connecting
> thread, so if the chardev is still connecting by the end of the test,
> then the chardev object won't be freed. This in turn means that the yank
> instance won't be unregistered and when running the next test-case
> yank_register_instance will abort, because the yank instance is
> already/still registered.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
> tests/test-char.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v7 2/8] block/nbd.c: Add yank feature, (continued)
- [PATCH v7 2/8] block/nbd.c: Add yank feature, Lukas Straub, 2020/08/04
- [PATCH v7 3/8] chardev/char-socket.c: Add yank feature, Lukas Straub, 2020/08/04
- [PATCH v7 4/8] migration: Add yank feature, Lukas Straub, 2020/08/04
- [PATCH v7 5/8] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe, Lukas Straub, 2020/08/04
- [PATCH v7 6/8] io: Document thread-safety of qio_channel_shutdown, Lukas Straub, 2020/08/04
- [PATCH v7 7/8] MAINTAINERS: Add myself as maintainer for yank feature, Lukas Straub, 2020/08/04
- [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test, Lukas Straub, 2020/08/04
- Re: [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test,
Daniel P . Berrangé <=
- Re: [PATCH v7 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu, Lukas Straub, 2020/08/18