Re: [PATCH] crypto: Add spaces around operator

[no-reply]

Patchew URL: 
bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com/">https://patchew.org/QEMU/bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com
Subject: [PATCH] crypto: Add spaces around operator

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com -> 
patchew/bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com
Switched to a new branch 'test'
53a011e crypto: Add spaces around operator

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#24: FILE: crypto/aes.c:1083:
+        if (bits == 128)
[...]
-        else if (bits==192)
[...]
                 key->rounds = 12;
[...]

ERROR: braces {} are necessary for all arms of this statement
#27: FILE: crypto/aes.c:1085:
+        else if (bits == 192)
[...]
         else
[...]

ERROR: space prohibited after that open parenthesis '('
#49: FILE: crypto/desrfb.c:96:
+                        if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space prohibited before that close parenthesis ')'
#49: FILE: crypto/desrfb.c:96:
+                        if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space required before the open parenthesis '('
#49: FILE: crypto/desrfb.c:96:
+                        if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: trailing statements should be on next line
#49: FILE: crypto/desrfb.c:96:
+                        if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: braces {} are necessary for all arms of this statement
#49: FILE: crypto/desrfb.c:96:
+                        if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];
[...]

total: 7 errors, 0 warnings, 35 lines checked

Commit 53a011edf848 (crypto: Add spaces around operator) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/bb45d748-01e4-2fde-9fe3-32a7db4b64e7@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com