[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2?] nbd: Silence Coverity false positive
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH for-5.2?] nbd: Silence Coverity false positive |
|
Date: |
Thu, 12 Nov 2020 13:04:37 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/11/20 8:35 AM, Eric Blake wrote:
> - if (!full) {
> - /* last non dirty extent */
> - nbd_extent_array_add(es, end - start, 0);
> + if (!full && nbd_extent_array_add(es, end - start, 0) < 0) {
> + /* last non dirty extent, nothing to do if array was already full */
> }
Casting to (void) is another way to get rid of the warning.
I dunno which makes more sense here. Definitely the comment is helpful.
r~